From 554ff3e7220b87a232167896287115d693b125f2 Mon Sep 17 00:00:00 2001
From: David Burke <david@burkesoftware.com>
Date: Fri, 23 Jul 2021 16:42:03 -0400
Subject: [PATCH] Better default values and readme clarification

---
 README.md   |  6 +++++-
 values.yaml | 16 +++++++---------
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index a58110f..19d5a95 100644
--- a/README.md
+++ b/README.md
@@ -8,11 +8,15 @@ Based on https://gitlab.com/burke-software/django-helm-chart/
 # Usage
 
 1. Add our Helm chart repo `helm repo add glitchtip https://glitchtip.gitlab.io/glitchtip-helm-chart/`
-2. Review our values.yaml. At a minimum you'll need to set env.secret.DATABASE_URL and SECRET_KEY.
+2. Review our values.yaml. At a minimum you'll need to set env.secret.DATABASE_URL and env.secret.SECRET_KEY.
 3. Install the chart `helm install glitchtip/glitchtip`
 
+The default values assume a externally managed PostgresSQL database and a chart managed Redis. Redis in GlitchTip is ephemeral.
+
 # Tips
 
 - Use [helm diff](https://github.com/databus23/helm-diff) to preview changes
 - We don't version this chart at this time
 - Set image.tag to the GlitchTip version you wish to install
+- Set redis.auth.password to avoid redis being entirely remade on each release
+- If updating the chart, carefully review values for any new defaults
diff --git a/values.yaml b/values.yaml
index ee59b3d..4336cce 100644
--- a/values.yaml
+++ b/values.yaml
@@ -10,22 +10,21 @@ fullnameOverride: ""
 
 env:
   normal:
-    DATABASE_URL:
     ENABLE_SOCIAL_AUTH: false
     GLITCHTIP_DOMAIN: https://example.com
   secret:
-    SECRET_KEY:
-    REDIS_URL:
+    SECRET_KEY: # Required
+    # DATABASE_URL: Specify if using external postgres (not managed by this chart)
+    # REDIS_URL: Specify if using external redis (not managed by this chart)
 
 web:
   replicaCount: 2
   autoscaling:
     enabled: false
-    minReplicas: 1
+    minReplicas: 2
     maxReplicas: 10
     targetCPUUtilizationPercentage: 80
     # targetMemoryUtilizationPercentage: 80
-
   budget:
     minAvailable: 1
   resources:
@@ -110,13 +109,12 @@ serviceAccount:
 
 redis:
   enabled: true
+  architecture: standalone
+  # auth:
+  #  password: # Set this to avoid remaking redis on each release
   master:
     persistence:
       enabled: false
-  replica:
-    replicaCount: 1
-    persistence:
-      enabled: false
 
 # Default to disabled, use a managed database service. But can be enabled here.
 postgresql: